Nice scripts, very useful!

I’d just like to add that disabling Spanning Tree (STP) is not the wisest thing to do by default.

I suggest enabling STP, and remarking the line “brctl setfd ${bridge} 0″ en replace “off” by “on” on line “brctl stp ${bridge} off” Routing loops are nasty.

from ‘man brctl’:

brctl stp controls this bridge instance’s participa‐
tion in the spanning tree protocol. If is “on” or “yes” the
STP will be turned on, otherwise it will be turned off. When turned
off, the bridge will not send or receive BPDUs, and will thus not
participate in the spanning tree protocol. If your bridge isn’t the
only bridge on the LAN, or if there are loops in the LAN’s topology,
DO NOT turn this option off. If you turn this option off, please know
what you are doing.

Patch:

— network-bridge-vlan.old 2007-07-26 13:32:40.145832732 -0400
network-bridge-vlan 2007-07-26 13:19:50.593479432 -0400

@@ -76,8 76,8 @@
# Don’t create the bridge if it already exists.
if ! brctl show | grep -q ${bridge} ; then
brctl addbr ${bridge}
- brctl stp ${bridge} off
- brctl setfd ${bridge} 0
brctl stp ${bridge} on
#brctl setfd ${bridge} 0
fi
ip link set ${bridge} up
}

Cheers,

Otto

I was wondering if you ever tried to make something similar, or if you know that this works:

The DOMU’s are firewalls with multiple VLAN interfaces on the inside, and one normal interface on the outside, like this:

DOMu1 — eth0 (external-if) — xenbr0 — eth0 (Dom0)
— eth2.2 (internal-if)
— eth2.3 (internal-if)
— eth2.4 (internal-if)

DOMu2 — eth0 (external-if) — xenbr0 — eth0 (Dom0)
— eth2.2 (internal-if)
— eth2.3 (internal-if)
— eth2.4 (internal-if)

I’ve tried a series of bridges/setups that never worked when trying to ping DOMu2 eth2.2 from DOMu1 (thats why i didnt included any bridge information on the eth2.x interfaces of the DOMu’s). Nothing that i’ve tried so far made those DOMu’s vlan interfaces to communicate.

Any toughts about that would b extremely valuable,

Thanks a lot and keep up the good work!